linux-kernel - Re: [PATCH] HID: logitech-hidpp: add support for the Powerplay mat/receiver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jan 2020 00:55:14 +0000
From:   Filipe Laíns <lains@...hlinux.org>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: logitech-hidpp: add support for the Powerplay
 mat/receiver

On Tue, 2020-01-14 at 20:48 +1000, Benjamin Tissoires wrote:
> On Tue, Jan 14, 2020 at 1:31 AM Filipe Laíns <lains@...hlinux.org>
> wrote:
> > On Sun, 2020-01-12 at 20:50 +0000, Filipe Laíns wrote:
> > > I also marked all lightspeed devices as HID++ compatible. As the
> > > internal powerplay device does not have REPORT_TYPE_KEYBOARD or
> > > REPORT_TYPE_KEYBOARD it was not being marked as HID++ compatible
> > > in
> > > logi_hidpp_dev_conn_notif_equad.
> > 
> > Actually I had another look at the code and I don't understand why
> > we
> > are manually setting |= HIDPP in
> > logi_hidpp_dev_conn_notif_equad/logi_hidpp_dev_conn_notif_27mhz. We
> > should set it in logi_dj_hidpp_event as it is triggered by
> > receiving a
> > HID++ packet.
> 
> long story short: nope :)
> 
> The whole purpose of setting the workitem->reports_supported is to be
> able to create the matching report descriptor in the new virtual
> device. So having this set in a callback will add an operation for
> nothing every time we get an event, and will also not ensure a proper
> separation of concerns.
> 
> Cheers,
> Benjamin
> 
> > What do you think Benjamin?
> > 
> > --
> > Filipe Laíns

Okay, then is maybe better if I add HIDPP to reports_supported based on
the device ID (7). This is the only product to my knowledge that
exports a device with ID 7. It's a better solution than setting HIDPP
on all lightspeed devices.

I will send a new patch if you agree with this approach.

-- 
Filipe Laíns

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)