linux-kernel - Re: [PATCH] HID: logitech-dj: add debug msg when exporting a HID++ report descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO-hwJKkMv7T0e11XoYKh9GtsnNCfOztFsoU7JXgmxCvfROeZw@mail.gmail.com>
Date:   Tue, 14 Jan 2020 11:24:08 +1000
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Filipe Laíns <lains@...hlinux.org>
Cc:     Jiri Kosina <jikos@...nel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: logitech-dj: add debug msg when exporting a HID++
 report descriptors

Hi Filipe,

On Tue, Jan 14, 2020 at 5:23 AM Filipe Laíns <lains@...hlinux.org> wrote:
>
> When exporting all other types of report descriptors we print a debug
> message. Not doing so for HID++ descriptors makes unaware users think
> that no HID++ descriptor was exported.

Unless I am mistaken, those dbg_hid() calls are not displayed by
default on any distribution. So I am not sure what is the benefit to
add this one here when we are already not showing the rest to the
users by default. There is a tiny improvement to have some code
symmetry, but here, honestly, it doesn't feel that required.

Cheers,
Benjamin

>
> Signed-off-by: Filipe Laíns <lains@...hlinux.org>
> ---
>  drivers/hid/hid-logitech-dj.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> index cc7fc71d8b05..8f17a29b5a94 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -1368,6 +1368,8 @@ static int logi_dj_ll_parse(struct hid_device *hid)
>         }
>
>         if (djdev->reports_supported & HIDPP) {
> +               dbg_hid("%s: sending a HID++ descriptor, reports_supported: %llx\n",
> +                       __func__, djdev->reports_supported);
>                 rdcat(rdesc, &rsize, hidpp_descriptor,
>                       sizeof(hidpp_descriptor));
>         }
> --
> 2.24.1
>