linux-kernel - Re: [PATCH v2] cpu-topology: Skip the exist but not possible cpu nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jan 2020 10:29:56 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     "Zengtao (B)" <prime.zeng@...ilicon.com>
Cc:     Linuxarm <linuxarm@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v2] cpu-topology: Skip the exist but not possible cpu
 nodes

On Tue, Jan 14, 2020 at 01:42:25AM +0000, Zengtao (B) wrote:
> Could you help to explain here?
> I understand there are two abnormal cases:
> 1. The cpu node exist in the device tree, but not a possible cpu.
> This case can be caught by of_cpu_node_to_id's return value.

Yes if of_cpu_node_to_id returns -ENODEV, it means there's no logical
CPU associated with this DT node.

> 2. The cpu node does not exist. This case can be caught by above logic. Or
> do you think of_parse_phandle's return value is enough?

Again yes, there's nothing extra needed.

The only change you need is to consider -ENODEV while handling the case(1)

--
Regards,
Sudeep