linux-kernel - Re: [PATCH v6 2/4] dt-bindings: regulator: add document bindings for mpq7920

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200114123324.GS3897@sirena.org.uk>
Date:   Tue, 14 Jan 2020 12:33:24 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Saravanan Sekar <sravanhome@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Maxime Ripard <mripard@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        "heiko@...ech.de" <heiko@...ech.de>,
        Sam Ravnborg <sam@...nborg.org>,
        Icenowy Zheng <icenowy@...c.io>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        David Miller <davem@...emloft.net>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 2/4] dt-bindings: regulator: add document bindings for
 mpq7920

On Mon, Jan 13, 2020 at 10:56:55AM -0600, Rob Herring wrote:
> On Thu, Jan 9, 2020 at 5:26 AM Saravanan Sekar <sravanhome@...il.com> wrote:

> > Add device tree binding information for mpq7920 regulator driver.
> > Example bindings for mpq7920 are added.

> Mark, Please revert this. Not even close to valid schema and my
> questions on v4 are unanswered.

OK...  I didn't see any comments on V5.

> > +      mps,switch-freq:

> As I asked on v4, shouldn't this be a common property? Switching
> frequency is a common property for switching regulators, right?

It's not very common and where it's offered the valid values are
generally highly constrained so I'm not sure it makes sense to do
that, any device that does have this feature will want to specify
the valid values for that particular device.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)