linux-kernel - Re: [PATCH v6] ASoC: Add MediaTek MT6660 Speaker Amp Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hh80ycgnd.wl-tiwai@suse.de>
Date:   Tue, 14 Jan 2020 14:27:18 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Mark Brown <broonie@...nel.org>
Cc:     Jeff Chang <richtek.jeff.chang@...il.com>, lgirdwood@...il.com,
        perex@...ex.cz, tiwai@...e.com, matthias.bgg@...il.com,
        alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, jeff_chang@...htek.com
Subject: Re: [PATCH v6] ASoC: Add MediaTek MT6660 Speaker Amp Driver

On Tue, 14 Jan 2020 13:47:44 +0100,
Mark Brown wrote:
> 
> On Tue, Jan 14, 2020 at 08:44:22AM +0100, Takashi Iwai wrote:
> > Jeff Chang wrote:
> 
> > > +	if (ret < 0)
> > > +		return ret;
> > > +	reg_data = (u8)ret;
> > > +	if (on_off)
> > > +		reg_data &= (~0x01);
> > > +	else
> > > +		reg_data |= 0x01;
> > > +	return regmap_write(chip->regmap, MT6660_REG_SYSTEM_CTRL, reg_data);
> 
> > Hm, this looks like an open-code of forced update bits via regmap.
> > But interestingly there is no corresponding standard helper for that.
> > Essentially it should be regmap_update_bits_base() with force=1.
> 
> > Mark?
> 
> regmap_write_bits().

Oh that obvious one, thanks :)


Takashi