linux-kernel - Re: [PATCH v2] KVM: nVMX: vmread should not set rflags to specify success in case of #PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <724c22eff5f94a338e0f8af4f2c1df93@huawei.com>
Date:   Tue, 14 Jan 2020 02:15:28 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
CC:     "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "liran.alon@...cle.com" <liran.alon@...cle.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v2] KVM: nVMX: vmread should not set rflags to specify
 success in case of #PF

Hi,
On Mon, Jan 13, 2020 at 12:09:42PM -0800, Sean Christopherson wrote:
> > On Sat, Dec 28, 2019 at 02:25:24PM +0800, linmiaohe wrote:
> > > From: Miaohe Lin <linmiaohe@...wei.com>
> > > 
> > > In case writing to vmread destination operand result in a #PF, 
> > vmread should not call nested_vmx_succeed() to set rflags to specify success.
> > > Similar to as done in VMPTRST (See handle_vmptrst()).
> > > 
> > > Reviewed-by: Liran Alon <liran.alon@...cle.com>
> > > Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> > 
> > Reviewed-by: Sean Christopherson <sean.j.christopherson@...el.com>
>
> Gah, got trigger happy.  This could also have "Cc: stable@...r.kernel.org".
> With that, my Reviewed-by stands :-).

Many thanks for your review. I would add Cc tag and resend a v3. Thanks again.