linux-kernel - RE: [PATCH v2] x86/mce/therm_throt: Fix the access of uninitialized therm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jan 2020 02:19:22 +0000
From:   "Liu, Chuansheng" <chuansheng.liu@...el.com>
To:     Borislav Petkov <bp@...en8.de>, "Luck, Tony" <tony.luck@...el.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>
Subject: RE: [PATCH v2] x86/mce/therm_throt: Fix the access of uninitialized
 therm_work



> -----Original Message-----
> From: Borislav Petkov <bp@...en8.de>
> Sent: Monday, January 13, 2020 5:05 PM
> To: Luck, Tony <tony.luck@...el.com>
> Cc: Liu, Chuansheng <chuansheng.liu@...el.com>; linux-
> kernel@...r.kernel.org; tglx@...utronix.de; mingo@...hat.com;
> hpa@...or.com
> Subject: Re: [PATCH v2] x86/mce/therm_throt: Fix the access of uninitialized
> therm_work
> 
> On Fri, Jan 10, 2020 at 10:29:29AM -0800, Luck, Tony wrote:
> > On Tue, Jan 07, 2020 at 12:41:16AM +0000, Chuansheng Liu wrote:
> > > In my ICL platform, it can be reproduced in several times
> > > of reboot stress. With this fix, the system keeps alive
> > > for more than 200 times of reboot stress.
> > >
> > > V2: Boris shares a good suggestion that we can moving the
> > > interrupt unmasking at the end of therm_work initialization.
> > >
> > > Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> >
> > Looks good to me:
> >
> > Acked-by: Tony Luck <tony.luck@...el.com>
> 
> Thx.
> 
> This "ICL platform" - whatever that is - is this shipping already so
I just can say ICL(icelake) is shipped platform, I reproduced this issue
in one laptop.