linux-kernel - Re: [PATCH 1/3] drivers: base: Support atomic version of attribute_container_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200114150530.GA1975425@kroah.com>
Date:   Tue, 14 Jan 2020 16:05:30 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>
Cc:     rafael@...nel.org, lduncan@...e.com, cleech@...hat.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com,
        open-iscsi@...glegroups.com, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH 1/3] drivers: base: Support atomic version of
 attribute_container_device_trigger

On Mon, Jan 06, 2020 at 01:58:15PM -0500, Gabriel Krisman Bertazi wrote:
> attribute_container_device_trigger invokes callbacks that may fail for
> one or more classdev's, for instance, the transport_add_class_device
> callback, called during transport creation, does memory allocation.
> This information, though, is not propagated to upper layers, and any
> driver using the attribute_container_device_trigger API will not know
> whether any, some, or all callbacks succeeded.
> 
> This patch implements a safe version of this dispatcher, to either
> succeed all the callbacks or revert to the original state.
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>