linux-kernel - Re: reiserfs broke between 4.9.205 and 4.9.208

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72d4425c-a3a3-4369-fe19-b5673d73a02a@suse.com>
Date:   Wed, 15 Jan 2020 12:39:30 -0500
From:   Jeff Mahoney <jeffm@...e.com>
To:     Michael Brunnbauer <brunni@...estate.de>, Jan Kara <jack@...e.cz>
Cc:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
        reiserfs-devel@...r.kernel.org
Subject: Re: reiserfs broke between 4.9.205 and 4.9.208

Nevermind.  I just wasn't reproducing properly.  Jan's analysis is
right.  The -EOPNOTSUPP change is required so that we get the right
error when explicit xattr operations are performed on a file system
without them.  Prior to this change, we'd get -EOPNOTSUPP by sb->s_xattr
being NULL.

reiserfs_for_each_xattr needs to handle this the same way we already
handle -ENODATA.

-Jeff

On 1/15/20 12:03 PM, Jeff Mahoney wrote:
> Hi Michael -
> 
> It looks like something must've gone sideways with the backport since
> 5.5-rc6 works as expected.  I'll dig into it a bit.
> 
> -Jeff
> 
> On 1/14/20 3:21 PM, Michael Brunnbauer wrote:
>>
>> hi all,
>>
>> is this been looked into? Do you need more information?
>>
>> Regards,
>>
>> Michael Brunnbauer
>>
>> On Thu, Jan 09, 2020 at 01:30:41PM +0100, Michael Brunnbauer wrote:
>>>
>>> Hello Jan,
>>>
>>> On Thu, Jan 09, 2020 at 01:12:16PM +0100, Jan Kara wrote:
>>>> Also Michael, I'd like to clarify: Does 'cp -a' return any error or is it
>>>> just that the kernel is spewing these annoying warnings?  Because from the
>>>> code reading I'd think that it is only the kernel spewing errors but
>>>> userspace should be fine...
>>>
>>> Yes, 'cp -a' returns errors and files are owned by root instead of the correct
>>> user after copying as root.
>>>
>>> Regards,
>>>
>>> Michael Brunnbauer
> 
> 


-- 
Jeff Mahoney
Director, SUSE Labs Data & Performance



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)