linux-kernel - Re: [PATCH 5/6] KVM: x86: check kvm_pit outside kvm_vm_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Jan 2020 18:53:27 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     linmiaohe <linmiaohe@...wei.com>, rkrcmar@...hat.com,
        sean.j.christopherson@...el.com, vkuznets@...hat.com,
        wanpengli@...cent.com, jmattson@...gle.com, joro@...tes.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH 5/6] KVM: x86: check kvm_pit outside
 kvm_vm_ioctl_reinject()

On 07/12/19 10:25, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@...wei.com>
> 
> check kvm_pit outside kvm_vm_ioctl_reinject() to keep codestyle consistent
> with other kvm_pit func and prepare for futher cleanups.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  arch/x86/kvm/x86.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 2d4e3a2dfec6..00b5d4ace383 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -4662,9 +4662,6 @@ static int kvm_vm_ioctl_reinject(struct kvm *kvm,
>  {
>  	struct kvm_pit *pit = kvm->arch.vpit;
>  
> -	if (!pit)
> -		return -ENXIO;
> -
>  	/* pit->pit_state.lock was overloaded to prevent userspace from getting
>  	 * an inconsistent state after running multiple KVM_REINJECT_CONTROL
>  	 * ioctls in parallel.  Use a separate lock if that ioctl isn't rare.
> @@ -5029,6 +5026,9 @@ long kvm_arch_vm_ioctl(struct file *filp,
>  		r =  -EFAULT;
>  		if (copy_from_user(&control, argp, sizeof(control)))
>  			goto out;
> +		r = -ENXIO;
> +		if (!kvm->arch.vpit)
> +			goto out;
>  		r = kvm_vm_ioctl_reinject(kvm, &control);
>  		break;
>  	}
> 

Applied this one, I don't think the others are a useful improvement.

Paolo