linux-kernel - Re: [PATCH] i2c: iop3xx: Fix memory leak in probe error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200115193314.GA23789@ninjato>
Date:   Wed, 15 Jan 2020 20:33:14 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: iop3xx: Fix memory leak in probe error path

On Mon, Jan 13, 2020 at 06:29:54PM +0100, Krzysztof Kozlowski wrote:
> When handling devm_gpiod_get_optional() errors, free the memory already
> allocated.  This fixes Smatch warnings:
> 
>     drivers/i2c/busses/i2c-iop3xx.c:437 iop3xx_i2c_probe() warn: possible memory leak of 'new_adapter'
>     drivers/i2c/busses/i2c-iop3xx.c:442 iop3xx_i2c_probe() warn: possible memory leak of 'new_adapter'
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Applied to for-current, thanks! Please add a 'Fixes' tag next time,
added it for you now.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)