linux-kernel - Re: [PATCH v2 1/4] i2c: pmcmsp: Use proper printk format for resource_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200115195157.GA8661@kozik-lap>
Date:   Wed, 15 Jan 2020 20:51:57 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Vladimir Zapolskiy <vz@...ia.com>,
        Sylvain Lemieux <slemieux.tyco@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Jean Delvare <jdelvare@...e.de>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Subject: Re: [PATCH v2 1/4] i2c: pmcmsp: Use proper printk format for
 resource_size_t

On Wed, Jan 15, 2020 at 06:45:53PM +0100, Wolfram Sang wrote:
> 
> > +			"Unable to get memory/io address region %pap\n",
> > +			&(res->start));
> 
> My first thought was "parens not needed"; not because I like being picky
> but because it doesn't look more readable to me.
> 
> checkpatch agrees:
> 
> CHECK: Unnecessary parentheses around res->start
> #30: FILE: drivers/i2c/busses/i2c-pmcmsp.c:278:
> +			&(res->start));

Indeed... let me send v3.

Best regards,
Krzysztof