linux-kernel - Re: [PATCH next] power: suppy: ucs1002: Make the symbol 'ucs1002_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200115205243.mqhlgwxazdz4n3ob@earth.universe>
Date:   Wed, 15 Jan 2020 21:52:43 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Chen Wandun <chenwandun@...wei.com>
Cc:     l.stach@...gutronix.de, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH next] power: suppy: ucs1002: Make the symbol
 'ucs1002_regulator_enable' static

Hi,

Thanks, queued.

-- Sebastian

On Fri, Dec 20, 2019 at 05:41:44PM +0800, Chen Wandun wrote:
> Fix the following sparse warning:
> 
> drivers/power/supply/ucs1002_power.c:492:5: warning: symbol 'ucs1002_regulator_enable' was not declared. Should it be static?
> 
> Fixes: a3d70dacc727 ("power: suppy: ucs1002: disable power when maxcurrent is 0")
> Signed-off-by: Chen Wandun <chenwandun@...wei.com>
> ---
>  drivers/power/supply/ucs1002_power.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/ucs1002_power.c b/drivers/power/supply/ucs1002_power.c
> index 0ca80d00b80a..cdb9a23d825f 100644
> --- a/drivers/power/supply/ucs1002_power.c
> +++ b/drivers/power/supply/ucs1002_power.c
> @@ -489,7 +489,7 @@ static irqreturn_t ucs1002_alert_irq(int irq, void *data)
>  	return IRQ_HANDLED;
>  }
>  
> -int ucs1002_regulator_enable(struct regulator_dev *rdev)
> +static int ucs1002_regulator_enable(struct regulator_dev *rdev)
>  {
>  	struct ucs1002_info *info = rdev_get_drvdata(rdev);
>  
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)