linux-kernel - Re: [PATCH v3] clocksource: Add driver for the Ingenic JZ47xx OST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87muaoxuck.fsf@nanos.tec.linutronix.de>
Date:   Wed, 15 Jan 2020 22:50:19 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Maarten ter Huurne <maarten@...ewalker.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>, od@...c.me,
        linux-kernel@...r.kernel.org, Mathieu Malaterre <malat@...ian.org>,
        Artur Rojek <contact@...ur-rojek.eu>
Subject: Re: [PATCH v3] clocksource: Add driver for the Ingenic JZ47xx OST

Paul Cercueil <paul@...pouillou.net> writes:
> Le mer., janv. 15, 2020 at 20:54, Thomas Gleixner <tglx@...utronix.de> 
>> That lock still a massive contention point as clock readouts can be 
>> pretty
>> frequent depending on workloads. Just think about tracing ...
>> 
>> So I really would avoid both the lock and that ugly 64bit readout 
>> thing.
>
> The 64bit readout thing is gone in V3.
>
> The lock cannot go away unless we have a way to retrieve the underlying 
> mmio pointer from the regmap, which the regmap maintainers will never 
> accept. So I can't really change that now. Besides, 
> drivers/clocksource/ingenic-timer.c also registers a clocksource that's 
> read with the regmap, and nobody complained.

I don't complain. I just told you that a spinlock in that code path is
really suboptimal.

I missed the one in the other driver, but the same problem exists there.

Thanks,

        tglx