linux-kernel - Re: [PATCH next] init/main.c: make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200116072034.93933a2acc82627b86e091bf@kernel.org>
Date:   Thu, 16 Jan 2020 07:20:34 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Mike Rapoport <rppt@...ux.ibm.com>
Cc:     Chen Zhou <chenzhou10@...wei.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        akpm@...ux-foundation.org, sfr@...b.auug.org.au,
        keescook@...omium.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH next] init/main.c: make some symbols static

Hi Chen Hulk and Mike,

Thanks for reporting.

This looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you!


On Wed, 15 Jan 2020 16:20:58 +0200
Mike Rapoport <rppt@...ux.ibm.com> wrote:

> (added Steven and Masami)
> 
> On Wed, Jan 15, 2020 at 09:54:58PM +0800, Chen Zhou wrote:
> > Make variable xbc_namebuf and function boot_config_checksum static to
> > fix build warnings, warnings are as follows:
> > 
> > init/main.c:254:6:
> > 	warning: symbol 'xbc_namebuf' was not declared. Should it be static?
> > init/main.c:330:5:
> > 	warning: symbol 'boot_config_checksum' was not declared. Should it be static?
> > 
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
> > ---
> >  init/main.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/init/main.c b/init/main.c
> > index a77114f..3a95591 100644
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -251,7 +251,7 @@ early_param("loglevel", loglevel);
> >  
> >  #ifdef CONFIG_BOOT_CONFIG
> >  
> > -char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
> > +static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
> >  
> >  #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)
> >  
> > @@ -327,7 +327,7 @@ static char * __init xbc_make_cmdline(const char *key)
> >  	return new_cmdline;
> >  }
> >  
> > -u32 boot_config_checksum(unsigned char *p, u32 size)
> > +static u32 boot_config_checksum(unsigned char *p, u32 size)
> >  {
> >  	u32 ret = 0;
> >  
> > -- 
> > 2.7.4
> > 
> 
> -- 
> Sincerely yours,
> Mike.
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>