linux-kernel - RE: Re: "oneshot" interrupt causes another interrupt to be fired erroneously in Haswell system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a76oxqv1.fsf@nanos.tec.linutronix.de>
Date:   Thu, 16 Jan 2020 00:05:38 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Kar Hin Ong <kar.hin.ong@...com>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-rt-users <linux-rt-users@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        "linux-pci\@vger.kernel.org" <linux-pci@...r.kernel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Julia Cartwright <julia.cartwright@...com>,
        Keng Soon Cheah <keng.soon.cheah@...com>
Subject: RE: Re: "oneshot" interrupt causes another interrupt to be fired erroneously in Haswell system

Kar Hin Ong <kar.hin.ong@...com> writes:
>> > > From Intel Xeon Processor E5/E7 v3 Product Family External Design
>> > > Specification (EDS), Volume One: Architecture, section 13.1 (Legacy
>> > > PCI Interrupt Handling), it mention: "If the I/OxAPIC entry is
>> > > masked (via the 'mask' bit in the corresponding Redirection Table
>> > > Entry), then the corresponding PCI Express interrupt(s) is forwarded
>> > > to the legacy PCH"
>> 
>> Oh well. Really useful behaviour - NOT!

Second thoughts on this. This behaviour is intentional to make PCI
interrupts work even when the IOAPIC is not initialized at all.

I don't have access to the document you mentioned, but I know that
chipsets have a knob to control that behaviour. Just checked a few
chipset docs and they contain the same sentence, but then in the next
paragraph they say:

 "If the I/OxAPIC entry is masked (via the mask bit in the corresponding
  Redirection Table Entry), then the corresponding PCI Express
  interrupt(s) is forwarded to the legacy ICH, provided the Disable PCI
  INTx Routing to ICH bit is clear, Section 19.10.2.27, QPIPINTRC: Intel
  QuickPath Interconnect Protocol Interrupt Control."

That control bit is 0 after reset, so the legacy forwarding works.

Another way to avoid this is to use MSI interrupts instead of the legacy
PCI ones, which is recommended for various reasons (including
performance) anyway.

Can you please provide the exact CPU and PCH types and the output of
'lspci -vvv'?

Thanks,

        tglx