linux-kernel - Re: [PATCH] watchdog: da9062: make restart handler atomic safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200115071957.j7sptgbmuilgs2lj@pengutronix.de>
Date:   Wed, 15 Jan 2020 08:19:57 +0100
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Stefan Lengfeld <contact@...fanchrist.eu>
Cc:     support.opensource@...semi.com, linux@...ck-us.net,
        Adam.Thomson.Opensource@...semi.com,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de
Subject: Re: [PATCH] watchdog: da9062: make restart handler atomic safe

Hi Stefan,

On 20-01-14 21:00, Stefan Lengfeld wrote:
> Hi Marco,
> 
> On Mon, Jan 13, 2020 at 10:15:21AM +0100, Marco Felsch wrote:
> > The restart handler is executed during the shutdown phase which is
> > atomic/irq-less. The i2c framework supports atomic transfers since
> > commit 63b96983a5dd ("i2c: core: introduce callbacks for atomic
> > transfers") but unfortunately the regmap framework doesn't support it
> > yet. Hard coding the i2c stuff can be done without worries since the
> > DA9062 is an i2c-only device.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>
> 
> Reviewed-by: Stefan Lengfeld <contact@...fanchrist.eu>
> 
> Thanks for picking up the patch and submitting it.

I will send a v2 to cover Guenter's suggestion. Can I keep your reviewed
by tag?

Regards,
  Marco

> Kind regards,
>     Stefan