linux-kernel - [PATCH] regulator: core: fixup regulator_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ftgh8qnn.wl-kuninori.morimoto.gx@renesas.com>
Date:   15 Jan 2020 10:17:00 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Marek Vasut <marex@...x.de>,
        Fabio Estevam <festevam@...il.com>,
        Igor Opaniuk <igor.opaniuk@...adex.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
Subject: [PATCH] regulator: core: fixup regulator_is_equal() helper


From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

commit b059b7e0ec320 ("regulator: core: Add regulator_is_equal() helper")
added regulator_is_equal() helper.
But it has unneeded ";" if CONFIG_REGULATOR was not defined.
Thus, we will have this error

linux/include/linux/regulator/consumer.h:600:1: error: expected \
identifier or '(' before '{' token
 {
 ^
linux/include/linux/regulator/consumer.h:599:1: warning: \
'regulator_is_equal' declared 'static' but never defined \
[-Wunused-function]
 regulator_is_equal(struct regulator *reg1, struct regulator *reg2);
 ^~~~~~~~~~~~~~~~~~

This patch fixup it.

Cc: Marek Vasut <marex@...x.de>
Cc: Fabio Estevam <festevam@...il.com>
Cc: Igor Opaniuk <igor.opaniuk@...adex.com>
Cc: Liam Girdwood <lgirdwood@...il.com>
Cc: Marcel Ziswiler <marcel.ziswiler@...adex.com>
Cc: Mark Brown <broonie@...nel.org>
Cc: Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
---
 include/linux/regulator/consumer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h
index 2c89d88..6a92fd3 100644
--- a/include/linux/regulator/consumer.h
+++ b/include/linux/regulator/consumer.h
@@ -596,7 +596,7 @@ regulator_bulk_set_supply_names(struct regulator_bulk_data *consumers,
 }
 
 static inline bool
-regulator_is_equal(struct regulator *reg1, struct regulator *reg2);
+regulator_is_equal(struct regulator *reg1, struct regulator *reg2)
 {
 	return false;
 }
-- 
2.7.4