linux-kernel - Re: [PATCH v10 05/14] exfat: add file operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0Hp4CiMQE8NrZt5vKrSn=-mYEbOXTC+Eqp35=pSocz+A@mail.gmail.com>
Date:   Wed, 15 Jan 2020 10:56:02 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Namjae Jeon <namjae.jeon@...sung.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        gregkh <gregkh@...uxfoundation.org>,
        Valdis Kletnieks <valdis.kletnieks@...edu>,
        Christoph Hellwig <hch@....de>, sj1557.seo@...sung.com,
        linkinjeon@...il.com,
        Pali Rohár <pali.rohar@...il.com>
Subject: Re: [PATCH v10 05/14] exfat: add file operations

On Wed, Jan 15, 2020 at 9:28 AM Namjae Jeon <namjae.jeon@...sung.com> wrote:

> +
> +               ktime_get_real_ts64(&ts);
> +               exfat_set_entry_time(sbi, &ts,
> +                               &ep->dentry.file.modify_time,
> +                               &ep->dentry.file.modify_date,
> +                               &ep->dentry.file.modify_tz);

I think this part should use current_time() instead of ktime_get_real_ts64()
so it gets truncated to the correct resolution and range.

Please also check if there are other callers of ktime_get_real_ts64() that
may need the same change.

      Arnd