lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jan 2020 11:25:22 +0100 From: Arnd Bergmann <arnd@...db.de> To: Namjae Jeon <namjae.jeon@...sung.com> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>, gregkh <gregkh@...uxfoundation.org>, Valdis Kletnieks <valdis.kletnieks@...edu>, Christoph Hellwig <hch@....de>, sj1557.seo@...sung.com, linkinjeon@...il.com, Pali Rohár <pali.rohar@...il.com> Subject: Re: [PATCH v10 03/14] exfat: add inode operations On Wed, Jan 15, 2020 at 9:28 AM Namjae Jeon <namjae.jeon@...sung.com> wrote: > + /* set FILE_INFO structure using the acquired struct exfat_dentry */ > + exfat_set_entry_time(sbi, &inode->i_ctime, > + &ep->dentry.file.create_time, > + &ep->dentry.file.create_date, > + &ep->dentry.file.create_tz); > + exfat_set_entry_time(sbi, &inode->i_mtime, > + &ep->dentry.file.modify_time, > + &ep->dentry.file.modify_date, > + &ep->dentry.file.modify_tz); > + exfat_set_entry_time(sbi, &inode->i_atime, > + &ep->dentry.file.access_time, > + &ep->dentry.file.access_date, > + &ep->dentry.file.access_tz); I wonder if i_ctime should be handled differently. With statx() we finally have a concept of "file creation time" in "stx_btime". so it would make sense to store dentry.file.create_time in there rather than in i_ctime. It seems that traditionally most file systems that cannot store ctime separately just set i_ctime and i_mtime both to what is is modify_time here, though fat and hpfs use i_ctime to refer to creation time. Arnd
Powered by blists - more mailing lists