linux-kernel - Re: [PATCH v4 02/12] vfio_pci: move vfio_pci_is_vga/vfio_vga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200115114322.31644ede.cohuck@redhat.com>
Date:   Wed, 15 Jan 2020 11:43:22 +0100
From:   Cornelia Huck <cohuck@...hat.com>
To:     Liu Yi L <yi.l.liu@...el.com>
Cc:     alex.williamson@...hat.com, kwankhede@...dia.com,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        kevin.tian@...el.com, joro@...tes.org, peterx@...hat.com,
        baolu.lu@...ux.intel.com
Subject: Re: [PATCH v4 02/12] vfio_pci: move
 vfio_pci_is_vga/vfio_vga_disabled to header file

On Tue,  7 Jan 2020 20:01:39 +0800
Liu Yi L <yi.l.liu@...el.com> wrote:

> This patch moves two inline functions to vfio_pci_private.h for further
> sharing across source files. Also avoids below compiling error in further
> code split.
> 
> "error: inlining failed in call to always_inline ‘vfio_pci_is_vga’:
> function body not available".

"We want to use these functions from other files, so move them to a
header" seems to be justification enough; why mention the compilation
error?

> 
> Cc: Kevin Tian <kevin.tian@...el.com>
> Cc: Lu Baolu <baolu.lu@...ux.intel.com>
> Signed-off-by: Liu Yi L <yi.l.liu@...el.com>
> ---
>  drivers/vfio/pci/vfio_pci.c         | 14 --------------
>  drivers/vfio/pci/vfio_pci_private.h | 14 ++++++++++++++
>  2 files changed, 14 insertions(+), 14 deletions(-)