linux-kernel - Re: [PATCH v4 05/11] mmc: sdhci: Convert sdhci_set_timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c534ec1-d673-2875-1a44-b3f7fc400b35@intel.com>
Date:   Wed, 15 Jan 2020 14:03:13 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Faiz Abbas <faiz_abbas@...com>, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mmc@...r.kernel.org
Cc:     kishon@...com, mark.rutland@....com, robh+dt@...nel.org,
        ulf.hansson@...aro.org, tony@...mide.com
Subject: Re: [PATCH v4 05/11] mmc: sdhci: Convert sdhci_set_timeout_irq() to
 non-static

On 6/01/20 1:01 pm, Faiz Abbas wrote:
> Export sdhci_set_timeout_irq() so that it is accessible from platform drivers.
> 
> Signed-off-by: Faiz Abbas <faiz_abbas@...com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci.c | 3 ++-
>  drivers/mmc/host/sdhci.h | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 8cc78c76bc3d..56f46bd7cdad 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -993,7 +993,7 @@ static void sdhci_set_transfer_irqs(struct sdhci_host *host)
>  	sdhci_writel(host, host->ier, SDHCI_SIGNAL_ENABLE);
>  }
>  
> -static void sdhci_set_data_timeout_irq(struct sdhci_host *host, bool enable)
> +void sdhci_set_data_timeout_irq(struct sdhci_host *host, bool enable)
>  {
>  	if (enable)
>  		host->ier |= SDHCI_INT_DATA_TIMEOUT;
> @@ -1002,6 +1002,7 @@ static void sdhci_set_data_timeout_irq(struct sdhci_host *host, bool enable)
>  	sdhci_writel(host, host->ier, SDHCI_INT_ENABLE);
>  	sdhci_writel(host, host->ier, SDHCI_SIGNAL_ENABLE);
>  }
> +EXPORT_SYMBOL_GPL(sdhci_set_data_timeout_irq);
>  
>  static void sdhci_set_timeout(struct sdhci_host *host, struct mmc_command *cmd)
>  {
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index 3166b3ecef89..928c6f35fcad 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -803,5 +803,6 @@ void sdhci_reset_tuning(struct sdhci_host *host);
>  void sdhci_send_tuning(struct sdhci_host *host, u32 opcode);
>  void sdhci_abort_tuning(struct sdhci_host *host, u32 opcode);
>  void sdhci_switch_external_dma(struct sdhci_host *host, bool en);
> +void sdhci_set_data_timeout_irq(struct sdhci_host *host, bool enable);
>  
>  #endif /* __SDHCI_HW_H */
>