linux-kernel - Re: [PATCH v4 07/11] mmc: sdhci-omap: Disable data timeout interrupt during erase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebec95f9-006f-2a13-05df-8b473e121d31@intel.com>
Date:   Wed, 15 Jan 2020 14:05:51 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Faiz Abbas <faiz_abbas@...com>, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mmc@...r.kernel.org
Cc:     kishon@...com, mark.rutland@....com, robh+dt@...nel.org,
        ulf.hansson@...aro.org, tony@...mide.com
Subject: Re: [PATCH v4 07/11] mmc: sdhci-omap: Disable data timeout interrupt
 during erase

On 6/01/20 1:01 pm, Faiz Abbas wrote:
> Disable data timeout interrupt during an erase operation
> 
> Signed-off-by: Faiz Abbas <faiz_abbas@...com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci-omap.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 84d85aa743da..1f05c8e98d62 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -7,6 +7,7 @@
>   */
>  
>  #include <linux/delay.h>
> +#include <linux/mmc/mmc.h>
>  #include <linux/mmc/slot-gpio.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
> @@ -827,6 +828,15 @@ static u32 sdhci_omap_irq(struct sdhci_host *host, u32 intmask)
>  	return intmask;
>  }
>  
> +static void sdhci_omap_set_timeout(struct sdhci_host *host,
> +				   struct mmc_command *cmd)
> +{
> +	if (cmd->opcode == MMC_ERASE)
> +		sdhci_set_data_timeout_irq(host, false);
> +
> +	__sdhci_set_timeout(host, cmd);
> +}
> +
>  static struct sdhci_ops sdhci_omap_ops = {
>  	.set_clock = sdhci_omap_set_clock,
>  	.set_power = sdhci_omap_set_power,
> @@ -838,6 +848,7 @@ static struct sdhci_ops sdhci_omap_ops = {
>  	.reset = sdhci_omap_reset,
>  	.set_uhs_signaling = sdhci_omap_set_uhs_signaling,
>  	.irq = sdhci_omap_irq,
> +	.set_timeout = sdhci_omap_set_timeout,
>  };
>  
>  static int sdhci_omap_set_capabilities(struct sdhci_omap_host *omap_host)
>