linux-kernel - RE: [PATCH v2] perf/imx_ddr: Fix cpu hotplug state cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB7PR04MB4618A6E19B905A0E19E3B316E6370@DB7PR04MB4618.eurprd04.prod.outlook.com>
Date:   Wed, 15 Jan 2020 01:36:17 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Leonard Crestez <leonard.crestez@....com>,
        Will Deacon <will@...nel.org>
CC:     Frank Li <frank.li@....com>, Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] perf/imx_ddr: Fix cpu hotplug state cleanup


> -----Original Message-----
> From: Leonard Crestez <leonard.crestez@....com>
> Sent: 2020年1月15日 4:26
> To: Joakim Zhang <qiangqing.zhang@....com>; Will Deacon <will@...nel.org>
> Cc: Frank Li <frank.li@....com>; Mark Rutland <mark.rutland@....com>;
> Peter Zijlstra <peterz@...radead.org>; Ingo Molnar <mingo@...hat.com>;
> Arnaldo Carvalho de Melo <acme@...nel.org>; Alexander Shishkin
> <alexander.shishkin@...ux.intel.com>; Jiri Olsa <jolsa@...hat.com>;
> Namhyung Kim <namhyung@...nel.org>; linux-kernel@...r.kernel.org
> Subject: [PATCH v2] perf/imx_ddr: Fix cpu hotplug state cleanup
> 
> This driver allocates a dynamic cpu hotplug state but never releases it.
> If reloaded in a loop it will quickly trigger a WARN message:
> 
> 	"No more dynamic states available for CPU hotplug"
> 
> Fix by calling cpuhp_remove_multi_state on remove like several other perf pmu
> drivers.
> 
> Also fix the cleanup logic on probe error paths: add the missing
> cpuhp_remove_multi_state call and properly check the return value from
> cpuhp_state_add_instant_nocalls.
> 
> Fixes: 9a66d36cc7ac ("drivers/perf: imx_ddr: Add DDR performance counter
> support to perf")
> Signed-off-by: Leonard Crestez <leonard.crestez@....com>
Acked-by: Joakim Zhang <qiangqing.zhang@....com>

Best Regards,
Joakim Zhang