lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c33046fc-c949-3705-a227-b9e2f8846d4d@samsung.com>
Date:   Wed, 15 Jan 2020 16:35:14 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Jiri Kosina <trivial@...nel.org>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v3] video: Fix Kconfig indentation


On 11/21/19 5:09 AM, Krzysztof Kozlowski wrote:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> 	$ sed -e 's/^        /\t/' -i */Kconfig
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

Patch queued for v5.6, thanks.
 
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> 
> Changes since v2:
> 1. Add Bartlomiej's ack.
> 
> Changes since v1:
> 1. Fix also 7-space and tab+1 space indentation issues.
> ---
>  drivers/video/Kconfig           |   4 +-
>  drivers/video/backlight/Kconfig |  16 ++---
>  drivers/video/console/Kconfig   | 132 ++++++++++++++++++++--------------------
>  3 files changed, 76 insertions(+), 76 deletions(-)
> 
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 427a993c7f57..74c2f39cec90 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -26,8 +26,8 @@ endmenu
>  source "drivers/video/backlight/Kconfig"
>  
>  config VGASTATE
> -       tristate
> -       default n
> +	tristate
> +	default n
>  
>  config VIDEOMODE_HELPERS
>  	bool
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 403707a3e503..e25fdd8ce3e7 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -9,7 +9,7 @@ menu "Backlight & LCD device support"
>  # LCD
>  #
>  config LCD_CLASS_DEVICE
> -        tristate "Lowlevel LCD controls"
> +	tristate "Lowlevel LCD controls"
>  	help
>  	  This framework adds support for low-level control of LCD.
>  	  Some framebuffer devices connect to platform-specific LCD modules
> @@ -141,10 +141,10 @@ endif # LCD_CLASS_DEVICE
>  # Backlight
>  #
>  config BACKLIGHT_CLASS_DEVICE
> -        tristate "Lowlevel Backlight controls"
> +	tristate "Lowlevel Backlight controls"
>  	help
>  	  This framework adds support for low-level control of the LCD
> -          backlight. This includes support for brightness and power.
> +	  backlight. This includes support for brightness and power.
>  
>  	  To have support for your specific LCD panel you will have to
>  	  select the proper drivers which depend on this option.
> @@ -269,11 +269,11 @@ config BACKLIGHT_MAX8925
>  	  WLED output, say Y here to enable this driver.
>  
>  config BACKLIGHT_APPLE
> -       tristate "Apple Backlight Driver"
> -       depends on X86 && ACPI
> -       help
> -         If you have an Intel-based Apple say Y to enable a driver for its
> -	 backlight.
> +	tristate "Apple Backlight Driver"
> +	depends on X86 && ACPI
> +	help
> +	  If you have an Intel-based Apple say Y to enable a driver for its
> +	  backlight.
>  
>  config BACKLIGHT_TOSA
>  	tristate "Sharp SL-6000 Backlight Driver"
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index c10e17fb9a9a..ed8480d324b1 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -23,26 +23,26 @@ config VGA_CONSOLE
>  	  Say Y.
>  
>  config VGACON_SOFT_SCROLLBACK
> -       bool "Enable Scrollback Buffer in System RAM"
> -       depends on VGA_CONSOLE
> -       default n
> -       help
> -         The scrollback buffer of the standard VGA console is located in
> -	 the VGA RAM.  The size of this RAM is fixed and is quite small.
> -	 If you require a larger scrollback buffer, this can be placed in
> -	 System RAM which is dynamically allocated during initialization.
> -	 Placing the scrollback buffer in System RAM will slightly slow
> -	 down the console.
> -
> -	 If you want this feature, say 'Y' here and enter the amount of
> -	 RAM to allocate for this buffer.  If unsure, say 'N'.
> +	bool "Enable Scrollback Buffer in System RAM"
> +	depends on VGA_CONSOLE
> +	default n
> +	help
> +	  The scrollback buffer of the standard VGA console is located in
> +	  the VGA RAM.  The size of this RAM is fixed and is quite small.
> +	  If you require a larger scrollback buffer, this can be placed in
> +	  System RAM which is dynamically allocated during initialization.
> +	  Placing the scrollback buffer in System RAM will slightly slow
> +	  down the console.
> +
> +	  If you want this feature, say 'Y' here and enter the amount of
> +	  RAM to allocate for this buffer.  If unsure, say 'N'.
>  
>  config VGACON_SOFT_SCROLLBACK_SIZE
> -       int "Scrollback Buffer Size (in KB)"
> -       depends on VGACON_SOFT_SCROLLBACK
> -       range 1 1024
> -       default "64"
> -       help
> +	int "Scrollback Buffer Size (in KB)"
> +	depends on VGACON_SOFT_SCROLLBACK
> +	range 1 1024
> +	default "64"
> +	help
>  	  Enter the amount of System RAM to allocate for scrollback
>  	  buffers of VGA consoles. Each 64KB will give you approximately
>  	  16 80x25 screenfuls of scrollback buffer.
> @@ -84,12 +84,12 @@ config MDA_CONSOLE
>  	  If unsure, say N.
>  
>  config SGI_NEWPORT_CONSOLE
> -        tristate "SGI Newport Console support"
> +	tristate "SGI Newport Console support"
>  	depends on SGI_IP22 && HAS_IOMEM
> -        select FONT_SUPPORT
> -        help
> -          Say Y here if you want the console on the Newport aka XL graphics
> -          card of your Indy.  Most people say Y here.
> +	select FONT_SUPPORT
> +	help
> +	  Say Y here if you want the console on the Newport aka XL graphics
> +	  card of your Indy.  Most people say Y here.
>  
>  config DUMMY_CONSOLE
>  	bool
> @@ -97,24 +97,24 @@ config DUMMY_CONSOLE
>  	default y
>  
>  config DUMMY_CONSOLE_COLUMNS
> -        int "Initial number of console screen columns"
> -        depends on DUMMY_CONSOLE && !ARM
> -        default 160 if PARISC
> -        default 80
> -        help
> -          On PA-RISC, the default value is 160, which should fit a 1280x1024
> -          monitor.
> -          Select 80 if you use a 640x480 resolution by default.
> +	int "Initial number of console screen columns"
> +	depends on DUMMY_CONSOLE && !ARM
> +	default 160 if PARISC
> +	default 80
> +	help
> +	  On PA-RISC, the default value is 160, which should fit a 1280x1024
> +	  monitor.
> +	  Select 80 if you use a 640x480 resolution by default.
>  
>  config DUMMY_CONSOLE_ROWS
> -        int "Initial number of console screen rows"
> -        depends on DUMMY_CONSOLE && !ARM
> -        default 64 if PARISC
> -        default 25
> -        help
> -          On PA-RISC, the default value is 64, which should fit a 1280x1024
> -          monitor.
> -          Select 25 if you use a 640x480 resolution by default.
> +	int "Initial number of console screen rows"
> +	depends on DUMMY_CONSOLE && !ARM
> +	default 64 if PARISC
> +	default 25
> +	help
> +	  On PA-RISC, the default value is 64, which should fit a 1280x1024
> +	  monitor.
> +	  Select 25 if you use a 640x480 resolution by default.
>  
>  config FRAMEBUFFER_CONSOLE
>  	bool "Framebuffer Console support"
> @@ -126,30 +126,30 @@ config FRAMEBUFFER_CONSOLE
>  	  Low-level framebuffer-based console driver.
>  
>  config FRAMEBUFFER_CONSOLE_DETECT_PRIMARY
> -       bool "Map the console to the primary display device"
> -       depends on FRAMEBUFFER_CONSOLE
> -       default n
> -       ---help---
> -         If this option is selected, the framebuffer console will
> -         automatically select the primary display device (if the architecture
> -	 supports this feature).  Otherwise, the framebuffer console will
> -         always select the first framebuffer driver that is loaded. The latter
> -         is the default behavior.
> +	bool "Map the console to the primary display device"
> +	depends on FRAMEBUFFER_CONSOLE
> +	default n
> +	---help---
> +	  If this option is selected, the framebuffer console will
> +	  automatically select the primary display device (if the architecture
> +	  supports this feature).  Otherwise, the framebuffer console will
> +	  always select the first framebuffer driver that is loaded. The latter
> +	  is the default behavior.
>  
> -	 You can always override the automatic selection of the primary device
> -	 by using the fbcon=map: boot option.
> +	  You can always override the automatic selection of the primary device
> +	  by using the fbcon=map: boot option.
>  
> -	 If unsure, select n.
> +	  If unsure, select n.
>  
>  config FRAMEBUFFER_CONSOLE_ROTATION
> -       bool "Framebuffer Console Rotation"
> -       depends on FRAMEBUFFER_CONSOLE
> -       help
> -         Enable display rotation for the framebuffer console.  This is done
> -         in software and may be significantly slower than a normally oriented
> -         display.  Note that the rotation is done at the console level only
> -         such that other users of the framebuffer will remain normally
> -         oriented.
> +	bool "Framebuffer Console Rotation"
> +	depends on FRAMEBUFFER_CONSOLE
> +	help
> +	  Enable display rotation for the framebuffer console.  This is done
> +	  in software and may be significantly slower than a normally oriented
> +	  display.  Note that the rotation is done at the console level only
> +	  such that other users of the framebuffer will remain normally
> +	  oriented.
>  
>  config FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER
>  	bool "Framebuffer Console Deferred Takeover"
> @@ -163,14 +163,14 @@ config FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER
>  	  black screen as soon as fbcon loads.
>  
>  config STI_CONSOLE
> -        bool "STI text console"
> +	bool "STI text console"
>  	depends on PARISC && HAS_IOMEM
> -        select FONT_SUPPORT
> -        default y
> -        help
> -          The STI console is the builtin display/keyboard on HP-PARISC
> -          machines.  Say Y here to build support for it into your kernel.
> -          The alternative is to use your primary serial port as a console.
> +	select FONT_SUPPORT
> +	default y
> +	help
> +	  The STI console is the builtin display/keyboard on HP-PARISC
> +	  machines.  Say Y here to build support for it into your kernel.
> +	  The alternative is to use your primary serial port as a console.
>  
>  endmenu
>  

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ