linux-kernel - Re: [PATCH v28 07/12] LRNG - add kernel crypto API PRNG extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jan 2020 16:15:46 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Stephan Müller <smueller@...onox.de>,
        Arnd Bergmann <arnd@...db.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-crypto@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-api@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        "Alexander E. Patrakov" <patrakov@...il.com>,
        "Ahmed S. Darwish" <darwish.07@...il.com>,
        "Theodore Y. Ts'o" <tytso@....edu>, Willy Tarreau <w@....eu>,
        Matthew Garrett <mjg59@...f.ucam.org>,
        Vito Caputo <vcaputo@...garu.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Jan Kara <jack@...e.cz>, Ray Strode <rstrode@...hat.com>,
        William Jon McCann <mccann@....edu>,
        zhangjs <zachary@...shancloud.com>,
        Andy Lutomirski <luto@...nel.org>,
        Florian Weimer <fweimer@...hat.com>,
        Lennart Poettering <mzxreary@...inter.de>,
        Nicolai Stange <nstange@...e.de>,
        "Peter, Matthias" <matthias.peter@....bund.de>,
        Marcelo Henrique Cerri <marcelo.cerri@...onical.com>,
        Roman Drahtmueller <draht@...altsekun.de>,
        Neil Horman <nhorman@...hat.com>,
        Julia Lawall <julia.lawall@...ia.fr>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v28 07/12] LRNG - add kernel crypto API PRNG extension

On 1/15/20 2:34 AM, Stephan Müller wrote:
> 
> CC: "Eric W. Biederman" <ebiederm@...ssion.com>
> CC: "Alexander E. Patrakov" <patrakov@...il.com>
> CC: "Ahmed S. Darwish" <darwish.07@...il.com>
> CC: "Theodore Y. Ts'o" <tytso@....edu>
> CC: Willy Tarreau <w@....eu>
> CC: Matthew Garrett <mjg59@...f.ucam.org>
> CC: Vito Caputo <vcaputo@...garu.com>
> CC: Andreas Dilger <adilger.kernel@...ger.ca>
> CC: Jan Kara <jack@...e.cz>
> CC: Ray Strode <rstrode@...hat.com>
> CC: William Jon McCann <mccann@....edu>
> CC: zhangjs <zachary@...shancloud.com>
> CC: Andy Lutomirski <luto@...nel.org>
> CC: Florian Weimer <fweimer@...hat.com>
> CC: Lennart Poettering <mzxreary@...inter.de>
> CC: Nicolai Stange <nstange@...e.de>
> Reviewed-by: Marcelo Henrique Cerri <marcelo.cerri@...onical.com>
> Reviewed-by: Roman Drahtmueller <draht@...altsekun.de>
> Tested-by: Roman Drahtmüller <draht@...altsekun.de>
> Tested-by: Marcelo Henrique Cerri <marcelo.cerri@...onical.com>
> Tested-by: Neil Horman <nhorman@...hat.com>
> Signed-off-by: Stephan Mueller <smueller@...onox.de>
> ---
>  drivers/char/lrng/Kconfig      |  10 +
>  drivers/char/lrng/Makefile     |   1 +
>  drivers/char/lrng/lrng_kcapi.c | 327 +++++++++++++++++++++++++++++++++
>  3 files changed, 338 insertions(+)
>  create mode 100644 drivers/char/lrng/lrng_kcapi.c
> 
> diff --git a/drivers/char/lrng/Kconfig b/drivers/char/lrng/Kconfig
> index 15fb623d9d1f..0d070a3897dd 100644
> --- a/drivers/char/lrng/Kconfig
> +++ b/drivers/char/lrng/Kconfig
> @@ -80,6 +80,16 @@ config LRNG_DRBG
>  	  Enable the SP800-90A DRBG support for the LRNG. Once the
>  	  module is loaded, output from /dev/random, /dev/urandom,
>  	  getrandom(2), or get_random_bytes is provided by a DRBG.
> +
> +config LRNG_KCAPI
> +	tristate "Kernel Crypto API support for the LRNG"
> +	select CRYPTO_RNG

Don't select CRYPTO_RNG unless you know that CRYPTO is set/enabled.

> +	help
> +	  Enable the support for generic pseudo-random number
> +	  generators offered by the kernel crypto API with the
> +	  LRNG. Once the module is loaded, output from /dev/random,
> +	  /dev/urandom, getrandom(2), or get_random_bytes is
> +	  provided by the selected kernel crypto API RNG.
>  endif # LRNG_DRNG_SWITCH
>  
>  endif # LRNG


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@...radead.org>