linux-kernel - Re: [PATCH] x86/cpu: clear X86_BUG_SPECTRE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d85ca29e-2249-a55d-5f2a-0cefc10772b2@zhaoxin.com>
Date:   Thu, 16 Jan 2020 11:51:39 +0800
From:   Tony W Wang-oc <TonyWWang-oc@...oxin.com>
To:     Thomas Gleixner <tglx@...utronix.de>, <mingo@...hat.com>,
        <bp@...en8.de>, <hpa@...or.com>, <x86@...nel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <DavidWang@...oxin.com>, <CooperYan@...oxin.com>,
        <QiyuanWang@...oxin.com>, <HerryYang@...oxin.com>
Subject: Re: [PATCH] x86/cpu: clear X86_BUG_SPECTRE_V2 on Zhaoxin family 7
 CPUs

On 16/01/2020 06:19, Thomas Gleixner wrote:
> Tony W Wang-oc <TonyWWang-oc@...oxin.com> writes:
> 
>> These CPUs are not affected by spectre_v2, so clear spectre_v2 bug flag
>> in their specific initialization code.
>>  
>>  	if (cpu_has(c, X86_FEATURE_VMX))
>>  		centaur_detect_vmx_virtcap(c);
>> +
>> +	if (c->x86 == 7) {
>> +		setup_clear_cpu_cap(X86_BUG_SPECTRE_V2);
>> +		clear_bit(X86_BUG_SPECTRE_V2, (unsigned long *)cpu_caps_set);
> 
> No. Please use cpu_vuln_whitelist. It exists for exactly this
> purpose. You just need to extend it with a NO_SPECTRE_V2 bit.

Got, done.

Sincerely
TonyWWang-oc