linux-kernel - Re: [PATCH v4] riscv: make sure the cores stay looping in .Lsecondary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhSdy0r1AZVW3JL-KoUi5eh_b78Bw2VogOBA8CidydK5RzJAw@mail.gmail.com>
Date:   Thu, 16 Jan 2020 09:58:53 +0530
From:   Anup Patel <anup@...infault.org>
To:     Paul Walmsley <paul.walmsley@...ive.com>
Cc:     Greentime Hu <greentime.hu@...ive.com>,
        Greentime Hu <green.hu@...il.com>, greentime@...nel.org,
        Palmer Dabbelt <palmer@...belt.com>,
        linux-riscv <linux-riscv@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org List" <linux-kernel@...r.kernel.org>,
        Andreas Schwab <schwab@...e.de>
Subject: Re: [PATCH v4] riscv: make sure the cores stay looping in .Lsecondary_park

On Thu, Jan 16, 2020 at 8:02 AM Paul Walmsley <paul.walmsley@...ive.com> wrote:
>
> On Wed, 15 Jan 2020, Greentime Hu wrote:
>
> > The code in secondary_park is currently placed in the .init section. The
> > kernel reclaims and clears this code when it finishes booting. That
> > causes the cores parked in it to go to somewhere unpredictable, so we
> > move this function out of init to make sure the cores stay looping there.
> >
> > The instruction bgeu a0, t0, .Lsecondary_park may have "a relocation
> > truncated to fit" issue during linking time. It is because that sections
> > are too far to jump. Let's use tail to jump to the .Lsecondary_park.
> >
> > Signed-off-by: Greentime Hu <greentime.hu@...ive.com>
>
> Thanks, queued for v5.5-rc.  Anup's Reviewed-by: has been dropped since
> the patch changed significantly - Anup, if you are still happy with it,
> please reply with another Reviewed-by:.  Thanks,

You can keep my Reviewed-by. I did not see any functional
changes in the patch so I am fine.

Thanks,
Anup