linux-kernel - Re: [PATCH] thermal: intel: fix unmatched pci_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <970ad09ea5ef05ca5bf158fdb9e5c9596e746fc5.camel@intel.com>
Date:   Thu, 16 Jan 2020 14:57:10 +0800
From:   Zhang Rui <rui.zhang@...el.com>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     Eduardo Valentin <edubezval@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amit.kucheria@...durent.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: intel: fix unmatched pci_release_region

On Fri, 2019-12-06 at 15:55 +0800, Chuhong Yuan wrote:
> The driver calls pci_request_regions() in probe and uses
> pci_release_regions() in probe failure.
> However, it calls pci_release_region() in remove, which does
> match the other two calls.
> Use pci_release_regions() instead to unify them.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>

Acked-by: Zhang Rui <rui.zhang@...el.com>
> ---
>  drivers/thermal/intel/intel_pch_thermal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/intel/intel_pch_thermal.c
> b/drivers/thermal/intel/intel_pch_thermal.c
> index 4f0bb8f502e1..5f7798b8d35f 100644
> --- a/drivers/thermal/intel/intel_pch_thermal.c
> +++ b/drivers/thermal/intel/intel_pch_thermal.c
> @@ -365,7 +365,7 @@ static void intel_pch_thermal_remove(struct
> pci_dev *pdev)
>  	thermal_zone_device_unregister(ptd->tzd);
>  	iounmap(ptd->hw_base);
>  	pci_set_drvdata(pdev, NULL);
> -	pci_release_region(pdev, 0);
> +	pci_release_regions(pdev);
>  	pci_disable_device(pdev);
>  }
>