linux-kernel - Re: [PATCH][next] tee: fix memory allocation failure checks on drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200116070544.doegatlwgsftbhc4@gondor.apana.org.au>
Date:   Thu, 16 Jan 2020 15:05:44 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     "Thomas, Rijo-john" <Rijo-john.Thomas@....com>
Cc:     Colin King <colin.king@...onical.com>,
        Jens Wiklander <jens.wiklander@...aro.org>,
        Devaraj Rangasamy <Devaraj.Rangasamy@....com>,
        Gary R Hook <gary.hook@....com>, tee-dev@...ts.linaro.org,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] tee: fix memory allocation failure checks on
 drv_data and amdtee

On Wed, Jan 08, 2020 at 12:33:08PM +0530, Thomas, Rijo-john wrote:
> +linux-crypto
> 
> On 07/01/20 8:06 pm, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > Currently the memory allocation failure checks on drv_data and
> > amdtee are using IS_ERR rather than checking for a null pointer.
> > Fix these checks to use the conventional null pointer check.
> > 
> > Addresses-Coverity: ("Dereference null return")
> > Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Reviewed-by: Rijo Thomas <Rijo-john.Thomas@....com>

This patch needs to be resubmitted to the linux-crypto list for
it to be picked up by patchwork.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt