linux-kernel - RE: [EXTERNAL] [PATCH AUTOSEL 4.9 177/251] cifs: fix rmmod regression in cifs.ko caused by force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN6PR2101MB1325121720B1E3645F2CF369E4360@SN6PR2101MB1325.namprd21.prod.outlook.com>
Date:   Thu, 16 Jan 2020 19:11:11 +0000
From:   Steven French <Steven.French@...rosoft.com>
To:     Sasha Levin <sashal@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
CC:     Ronnie Sahlberg <lsahlber@...hat.com>,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        "linux-cifs@...r.kernel.org" <linux-cifs@...r.kernel.org>,
        "samba-technical@...ts.samba.org" <samba-technical@...ts.samba.org>
Subject: RE: [EXTERNAL] [PATCH AUTOSEL 4.9 177/251] cifs: fix rmmod regression
 in cifs.ko caused by force_sig changes

I didn't think the patch that this fixes (72abe3bcf091) was in 4.9 (it was May 2019)?  Did Eric's patch to switch from force_sig to send_sig get backported as well?

-----Original Message-----
From: Sasha Levin <sashal@...nel.org> 
Sent: Thursday, January 16, 2020 9:35 AM
To: linux-kernel@...r.kernel.org; stable@...r.kernel.org
Cc: Steven French <Steven.French@...rosoft.com>; Ronnie Sahlberg <lsahlber@...hat.com>; Eric W . Biederman <ebiederm@...ssion.com>; Sasha Levin <sashal@...nel.org>; linux-cifs@...r.kernel.org; samba-technical@...ts.samba.org
Subject: [EXTERNAL] [PATCH AUTOSEL 4.9 177/251] cifs: fix rmmod regression in cifs.ko caused by force_sig changes

From: Steve French <stfrench@...rosoft.com>

[ Upstream commit 247bc9470b1eeefc7b58cdf2c39f2866ba651509 ]

Fixes: 72abe3bcf091 ("signal/cifs: Fix cifs_put_tcp_session to call send_sig instead of force_sig")

The global change from force_sig caused module unloading of cifs.ko to fail (since the cifsd process could not be killed, "rmmod cifs"
now would always fail)

Signed-off-by: Steve French <stfrench@...rosoft.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@...hat.com>
CC: Eric W. Biederman <ebiederm@...ssion.com>
Signed-off-by: Sasha Levin <sashal@...nel.org>
---
 fs/cifs/connect.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 110febd69737..7d46025d5e89 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -885,6 +885,7 @@ cifs_demultiplex_thread(void *p)
 		mempool_resize(cifs_req_poolp, length + cifs_min_rcv);
 
 	set_freezable();
+	allow_signal(SIGKILL);
 	while (server->tcpStatus != CifsExiting) {
 		if (try_to_freeze())
 			continue;
--
2.20.1