linux-kernel - Re: [PATCH][next] power: supply: bq25890_charger: fix incorrect error return when bq25890_field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200116193821.eahey33llmtmahhj@earth.universe>
Date:   Thu, 16 Jan 2020 20:38:21 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Yauhen Kharuzhy <jekhor@...il.com>, linux-pm@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] power: supply: bq25890_charger: fix incorrect
 error return when bq25890_field_read fails

Hi Colin,

Thanks, queued.

-- Sebastian

On Thu, Jan 16, 2020 at 05:09:00PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently a read failure by bq25890_field_read on F_DEV_REV is returning
> an error in id instead of rev. Fix this by returning the value in rev.
> 
> Addresses-Coverity: ("Copy-paste error")
> Fixes: d20267c9a98e ("power: supply: bq25890_charger: Add support of BQ25892 and BQ25896 chips")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/power/supply/bq25890_charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
> index 785dbc6307b0..aebd1253dbc9 100644
> --- a/drivers/power/supply/bq25890_charger.c
> +++ b/drivers/power/supply/bq25890_charger.c
> @@ -765,7 +765,7 @@ static int bq25890_get_chip_version(struct bq25890_device *bq)
>  	rev = bq25890_field_read(bq, F_DEV_REV);
>  	if (rev < 0) {
>  		dev_err(bq->dev, "Cannot read chip revision.\n");
> -		return id;
> +		return rev;
>  	}
>  
>  	switch (id) {
> -- 
> 2.24.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)