linux-kernel - Re: [PATCH] software node: property entry kunit tests must depend on KUNIT=y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFd5g47_yrZEHvCHUpc-b-hpMzXzJmaXxevcwpVHhs=2BFR+Bg@mail.gmail.com>
Date:   Thu, 16 Jan 2020 15:27:56 -0800
From:   Brendan Higgins <brendanhiggins@...gle.com>
To:     Alan Maguire <alan.maguire@...cle.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Greg KH <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH] software node: property entry kunit tests must depend on KUNIT=y

On Thu, Jan 16, 2020 at 3:19 AM Alan Maguire <alan.maguire@...cle.com> wrote:
>
> property entry kunit tests are built if CONFIG_KUNIT_DRIVER_PE_TEST
> (a boolean) is 'y'; it in turn depends on CONFIG_KUNIT.  However to
> ensure clean merge with linux-next, where CONFIG_KUNIT is tristate,
> we need to explicitly specify KUNIT=y as a dependency, otherwise
> allmodconfig builds will build kunit as a module and fail to build
> the property entry tests.  Later CONFIG_KUNIT_DRIVER_PE_TEST can
> be converted to tristate.
>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Fixes: 27f9d7e984d9 ("software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST")
> Signed-off-by: Alan Maguire <alan.maguire@...cle.com>

Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>

Thanks!