linux-kernel - Re: [PATCH] usb: gadget: ffs: ffs_aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3f8e2a6480da78ba23ddedb68beee71f47e178f.camel@analog.com>
Date:   Thu, 16 Jan 2020 11:13:42 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "mina86@...a86.com" <mina86@...a86.com>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "balbi@...nel.org" <balbi@...nel.org>
Subject: Re: [PATCH] usb: gadget: ffs: ffs_aio_cancel(): Save/restore IRQ
 flags

On Wed, 2019-11-06 at 14:02 +0200, Alexandru Ardelean wrote:
> From: Lars-Peter Clausen <lars@...afoo.de>
> 
> ffs_aio_cancel() can be called from both interrupt and thread context.
> Make
> sure that the current IRQ state is saved and restored by using
> spin_{un,}lock_irq{save,restore}().
> 
> Otherwise undefined behavior might occur.

Hey,

This is a patch-ping.

Thanks
Alex

> 
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
> ---
>  drivers/usb/gadget/function/f_fs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/f_fs.c
> b/drivers/usb/gadget/function/f_fs.c
> index 59d9d512dcda..ed3bcbb84b95 100644
> --- a/drivers/usb/gadget/function/f_fs.c
> +++ b/drivers/usb/gadget/function/f_fs.c
> @@ -1160,18 +1160,19 @@ static int ffs_aio_cancel(struct kiocb *kiocb)
>  {
>  	struct ffs_io_data *io_data = kiocb->private;
>  	struct ffs_epfile *epfile = kiocb->ki_filp->private_data;
> +	unsigned long flags;
>  	int value;
>  
>  	ENTER();
>  
> -	spin_lock_irq(&epfile->ffs->eps_lock);
> +	spin_lock_irqsave(&epfile->ffs->eps_lock, flags);
>  
>  	if (likely(io_data && io_data->ep && io_data->req))
>  		value = usb_ep_dequeue(io_data->ep, io_data->req);
>  	else
>  		value = -EINVAL;
>  
> -	spin_unlock_irq(&epfile->ffs->eps_lock);
> +	spin_unlock_irqrestore(&epfile->ffs->eps_lock, flags);
>  
>  	return value;
>  }