linux-kernel - RE: [PATCH v4 02/12] vfio_pci: move vfio_pci_is_vga/vfio_vga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A2975661238FB949B60364EF0F2C25743A183F44@SHSMSX104.ccr.corp.intel.com>
Date:   Thu, 16 Jan 2020 12:46:04 +0000
From:   "Liu, Yi L" <yi.l.liu@...el.com>
To:     Cornelia Huck <cohuck@...hat.com>
CC:     "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "kwankhede@...dia.com" <kwankhede@...dia.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "Tian, Kevin" <kevin.tian@...el.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "peterx@...hat.com" <peterx@...hat.com>,
        "baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>
Subject: RE: [PATCH v4 02/12] vfio_pci: move
 vfio_pci_is_vga/vfio_vga_disabled to header file

> From: Cornelia Huck [mailto:cohuck@...hat.com]
> Sent: Wednesday, January 15, 2020 6:43 PM
> To: Liu, Yi L <yi.l.liu@...el.com>
> Subject: Re: [PATCH v4 02/12] vfio_pci: move vfio_pci_is_vga/vfio_vga_disabled to
> header file
> 
> On Tue,  7 Jan 2020 20:01:39 +0800
> Liu Yi L <yi.l.liu@...el.com> wrote:
> 
> > This patch moves two inline functions to vfio_pci_private.h for
> > further sharing across source files. Also avoids below compiling error
> > in further code split.
> >
> > "error: inlining failed in call to always_inline ‘vfio_pci_is_vga’:
> > function body not available".
> 
> "We want to use these functions from other files, so move them to a header" seems
> to be justification enough; why mention the compilation error?

Exactly. What a stupid commit message I made. Thanks very much. I
encountered such compilation error during one step in my development,
so added it in the commit message. I agree it is not necessary.

Thanks,
Yi Liu

> >
> > Cc: Kevin Tian <kevin.tian@...el.com>
> > Cc: Lu Baolu <baolu.lu@...ux.intel.com>
> > Signed-off-by: Liu Yi L <yi.l.liu@...el.com>
> > ---
> >  drivers/vfio/pci/vfio_pci.c         | 14 --------------
> >  drivers/vfio/pci/vfio_pci_private.h | 14 ++++++++++++++
> >  2 files changed, 14 insertions(+), 14 deletions(-)