linux-kernel - Re: [PATCH] mm: memcg/slab: introduce mem_cgroup_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALvZod4opj-eMYmeK0KaOmFvbQV75ZgP=vAEu_x5MFdswDwSBA@mail.gmail.com>
Date:   Fri, 17 Jan 2020 12:54:43 -0800
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Roman Gushchin <guro@...com>
Cc:     Linux MM <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...nel.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Vladimir Davydov <vdavydov.dev@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Kernel Team <kernel-team@...com>,
        Yafang Shao <laoar.shao@...il.com>
Subject: Re: [PATCH] mm: memcg/slab: introduce mem_cgroup_from_obj()

On Fri, Jan 17, 2020 at 12:36 PM Roman Gushchin <guro@...com> wrote:
>
> Sometimes we need to get a memcg pointer from a charged kernel object.
> The right way to get it depends on whether it's a proper slab object
> or it's backed by raw pages (e.g. it's a vmalloc alloction). In the
> first case the kmem_cache->memcg_params.memcg indirection should be
> used; in other cases it's just page->mem_cgroup.
>
> To simplify this task and hide the implementation details let's
> introduce a mem_cgroup_from_obj() helper, which takes a pointer
> to any kernel object and returns a valid memcg pointer or NULL.
>
> Passing a kernel address rather than a pointer to a page will allow
> to use this helper for per-object (rather than per-page) tracked
> objects in the future.
>
> The caller is still responsible to ensure that the returned memcg
> isn't going away underneath: take the rcu read lock, cgroup mutex etc;
> depending on the context.
>
> mem_cgroup_from_kmem() defined in mm/list_lru.c is now obsolete
> and can be removed.
>
> Signed-off-by: Roman Gushchin <guro@...com>
> Acked-by: Yafang Shao <laoar.shao@...il.com>

Reviewed-by: Shakeel Butt <shakeelb@...gle.com>