linux-kernel - Re: Performance regression introduced by commit b667b8673443 ("pipe: Advance tail pointer inside of wait spinlock in pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABA31DpOsnDxL8VcwRebU8RmAMqv9UAc5zRe8oz14f3-TeWSQA@mail.gmail.com>
Date:   Fri, 17 Jan 2020 13:30:20 -0800
From:   Akemi Yagi <toracat@...epo.org>
To:     Waiman Long <longman@...hat.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        David Howells <dhowells@...hat.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>
Subject: Re: Performance regression introduced by commit b667b8673443 ("pipe:
 Advance tail pointer inside of wait spinlock in pipe_read()")

On Fri, Jan 17, 2020 at 10:11 AM Waiman Long <longman@...hat.com> wrote:
>
> On 1/17/20 12:29 PM, Waiman Long wrote:
> > On 1/17/20 12:05 PM, Linus Torvalds wrote:

> >> GNU make v4.2.1 is buggy. The fix was done over two years ago, but
> >> there hasn't been a new release since then, so a lot of distributions
> >> have the buggy version..
> >>
> >> The fix is commit b552b05 ("[SV 51159] Use a non-blocking read with
> >> pselect to avoid hangs.") In the make the git tree.
> >>      Linus
> >
> > Yes, I did use make v4.2.1 which is the version that is shipped in
> > RHEL8. I will build new make and try it.

> > Longman
> >
> I built a make with the lastest make git tree and the problem was gone
> with the new make. So it was a bug in make not the kernel. Sorry for the
> noise.
>
> Longman

If you are using RHEL8, building your own make is the only solution at
this time. There is a bugzilla entry filed for this make bug but the
progress is slow:

https://bugzilla.redhat.com/show_bug.cgi?id=1774790

The same bug in Fedora make was dealt with fairly quickly, thanks to
the great "pressure" from Linus. ;-)

Akemi