linux-kernel - Re: [PATCH 2/5] vringh: IOTLB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202001180622.NhhdCGp5%lkp@intel.com>
Date:   Sat, 18 Jan 2020 06:33:38 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     kbuild-all@...ts.01.org, mst@...hat.com, jasowang@...hat.com,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        tiwei.bie@...el.com, jgg@...lanox.com, maxime.coquelin@...hat.com,
        cunming.liang@...el.com, zhihong.wang@...el.com,
        rob.miller@...adcom.com, xiao.w.wang@...el.com,
        haotian.wang@...ive.com, lingshan.zhu@...el.com,
        eperezma@...hat.com, lulu@...hat.com, parav@...lanox.com,
        kevin.tian@...el.com, stefanha@...hat.com, rdunlap@...radead.org,
        hch@...radead.org, aadam@...hat.com, jakub.kicinski@...ronome.com,
        jiri@...lanox.com, shahafs@...lanox.com, hanand@...inx.com,
        mhabets@...arflare.com
Subject: Re: [PATCH 2/5] vringh: IOTLB support

Hi Jason,

I love your patch! Perhaps something to improve:

[auto build test WARNING on vhost/linux-next]
[also build test WARNING on linux/master linus/master v5.5-rc6 next-20200117]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200117-170243
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: sh-randconfig-a001-20200117 (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/vhost/vringh.c: In function 'copy_from_iotlb':
>> drivers/vhost/vringh.c:1110:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     ret = iotlb_translate(vrh, (u64)src, len, iov, 16, VHOST_MAP_RO);
                                ^
   drivers/vhost/vringh.c: In function 'copy_to_iotlb':
   drivers/vhost/vringh.c:1128:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     ret = iotlb_translate(vrh, (u64)dst, len, iov, 16, VHOST_MAP_WO);
                                ^
   drivers/vhost/vringh.c: In function 'getu16_iotlb':
   drivers/vhost/vringh.c:1145:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     ret = iotlb_translate(vrh, (u64)p, sizeof(*p),
                                ^
   drivers/vhost/vringh.c: In function 'putu16_iotlb':
   drivers/vhost/vringh.c:1166:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     ret = iotlb_translate(vrh, (u64)p, sizeof(*p),
                                ^

vim +1110 drivers/vhost/vringh.c

  1102	
  1103	static inline int copy_from_iotlb(const struct vringh *vrh, void *dst,
  1104					  void *src, size_t len)
  1105	{
  1106		struct iov_iter iter;
  1107		struct bio_vec iov[16];
  1108		int ret;
  1109	
> 1110		ret = iotlb_translate(vrh, (u64)src, len, iov, 16, VHOST_MAP_RO);
  1111		if (ret < 0)
  1112			return ret;
  1113	
  1114		iov_iter_bvec(&iter, READ, iov, ret, len);
  1115	
  1116		ret = copy_from_iter(dst, len, &iter);
  1117	
  1118		return ret;
  1119	}
  1120	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28673 bytes)