linux-kernel - Re: [PATCH v2] IMA: pre-allocate buffer to hold keyrings string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Jan 2020 22:36:21 -0500
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>,
        linux-integrity@...r.kernel.org
Cc:     sashal@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] IMA: pre-allocate buffer to hold keyrings string

On Thu, 2020-01-16 at 18:18 -0800, Lakshmi Ramasubramanian wrote:
> ima_match_keyring() is called while holding rcu read lock. Since this
> function executes in atomic context, it should not call any function
> that can sleep (such as kstrdup()).
> 
> This patch pre-allocates a buffer to hold the keyrings string read from
> the IMA policy and uses that to match the given keyring.
> 
> Signed-off-by: Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>
> Fixes: e9085e0ad38a ("IMA: Add support to limit measuring keys")

Thanks!  This patch is now queued in next-integrity-testing.

Mimi