linux-kernel - Re: [PATCH v2 2/9] scsi: ufs: Delete struct ufs_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afc473b1-6857-4cca-101d-2382f5314f0d@acm.org>
Date:   Thu, 16 Jan 2020 19:53:18 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Bean Huo <huobean@...il.com>, alim.akhtar@...sung.com,
        avri.altman@....com, asutoshd@...eaurora.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, stanley.chu@...iatek.com,
        beanhuo@...ron.com, tomas.winkler@...el.com, cang@...eaurora.org
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/9] scsi: ufs: Delete struct ufs_dev_desc

On 2020-01-16 13:59, Bean Huo wrote:
>  struct ufs_dev_fix {
> -	struct ufs_dev_desc card;
> +	u16 wmanufacturerid;
> +	u8 *model;
>  	unsigned int quirk;
>  };
>  
> -#define END_FIX { { 0 }, 0 }
> +#define END_FIX { 0 }

A minor comment: please use { } instead of { 0 }.

>  /* add specific device quirk */
>  #define UFS_FIX(_vendor, _model, _quirk) { \
> -	.card.wmanufacturerid = (_vendor),\
> -	.card.model = (_model),		   \
> +	.wmanufacturerid = (_vendor),\
> +	.model = (_model),		   \
>  	.quirk = (_quirk),		   \
>  }

Is this macro useful? Does it improve readability of the code? If not,
how about removing it (maybe later)?

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>