linux-kernel - Re: [PATCH] kconfig: fix documentation typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Jan 2020 19:54:43 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Masahiro Yamada <masahiroy@...nel.org>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Jonathan Corbet <corbet@....net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] kconfig: fix documentation typos

On 1/16/20 6:17 PM, Masahiro Yamada wrote:
> On Tue, Jan 14, 2020 at 8:22 AM Bjorn Helgaas <helgaas@...nel.org> wrote:
>>
>> From: Bjorn Helgaas <bhelgaas@...gle.com>
>>
>> Fix a couple typos in kconfig-language documentation.
>>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
>> ---
>>  Documentation/kbuild/kconfig-language.rst | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/kbuild/kconfig-language.rst b/Documentation/kbuild/kconfig-language.rst
>> index 74bef19f69f0..f547720bd82d 100644
>> --- a/Documentation/kbuild/kconfig-language.rst
>> +++ b/Documentation/kbuild/kconfig-language.rst
>> @@ -594,7 +594,7 @@ The two different resolutions for b) can be tested in the sample Kconfig file
>>  Documentation/kbuild/Kconfig.recursion-issue-02.
>>
>>  Below is a list of examples of prior fixes for these types of recursive issues;
>> -all errors appear to involve one or more select's and one or more "depends on".
>> +all errors appear to involve one or more "selects" and one or more "depends on".
> 
> 
> I think "selects" is strange here.

I thought so when I read it also.

> 
> "select" is a Kconfig keyword.
> select's is intentional, I guess.

Yes, I expect so.

> Keep it as-is, or perhaps change it into "select" (singular) ?

Maybe:

 Below is a list of examples of prior fixes for these types of recursive issues;
-all errors appear to involve one or more select's and one or more "depends on".
+all errors appear to involve one or more "select"s and one or more "depends on".


-- 
~Randy