linux-kernel - Re: [PATCH] microblaze: Wire CMA allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a347d18-9ac3-4141-77ae-9bd2ce7eb4bd@xilinx.com>
Date:   Fri, 17 Jan 2020 08:51:41 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Christoph Hellwig <hch@....de>,
        Michal Simek <michal.simek@...inx.com>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu, git@...inx.com,
        Andrew Morton <akpm@...ux-foundation.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Juergen Gross <jgross@...e.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Manish Narani <manish.narani@...inx.com>,
        Manjukumar Matha <manjukumar.harthikote-matha@...inx.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Max Filippov <jcmvbkbc@...il.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Stafford Horne <shorne@...il.com>,
        Will Deacon <will@...nel.org>
Subject: Re: [PATCH] microblaze: Wire CMA allocator

On 14. 01. 20 16:47, Christoph Hellwig wrote:
> On Tue, Jan 14, 2020 at 12:57:28PM +0100, Michal Simek wrote:
>> Based on commit 04e3543e228f ("microblaze: use the generic dma coherent remap allocator")
>> CMA can be easily enabled by calling dma_contiguous_reserve() at the end of
>> mmu_init(). High limit is end of lowmem space which is completely unused at
>> this point of time.
>>
>> Signed-off-by: Michal Simek <michal.simek@...inx.com>
>> ---
>>
>> Christoph: Can you please review this patch?
> 
> Looks sensible to me.  If you touch this area anyway I have a request,
> though:
> 
>> +++ b/arch/microblaze/include/asm/Kbuild
>> @@ -7,6 +7,7 @@ generic-y += bugs.h
>>  generic-y += compat.h
>>  generic-y += device.h
>>  generic-y += div64.h
>> +generic-y += dma-contiguous.h
> 
> Can you add a prep patch to add a
> 
> mandatory-y += dma-contiguous.h
> 
> to include/asm-generic/Kbuild and remove the generic-y in all the
> arch files?  That reduces the arch churn a little.

Sure not a problem.
M