linux-kernel - Re: [PATCH] cifs: Fix return value in __update_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5muybvVnEF=HzT1-xi=X2209PtE5F4zKr2OnMvaMcdLJHQ@mail.gmail.com>
Date:   Fri, 17 Jan 2020 01:53:07 -0600
From:   Steve French <smfrench@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Steve French <stfrench@...rosoft.com>, Paulo Alcantara <pc@....nz>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: Fix return value in __update_cache_entry

merged into cifs-2.6.git for-next

On Thu, Jan 16, 2020 at 9:58 PM YueHaibing <yuehaibing@...wei.com> wrote:
>
> copy_ref_data() may return error, it should be
> returned to upstream caller.
>
> Fixes: 03535b72873b ("cifs: Avoid doing network I/O while holding cache lock")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  fs/cifs/dfs_cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
> index 5617efe..03cfaa1 100644
> --- a/fs/cifs/dfs_cache.c
> +++ b/fs/cifs/dfs_cache.c
> @@ -593,7 +593,7 @@ static int __update_cache_entry(const char *path,
>
>         kfree(th);
>
> -       return 0;
> +       return rc;
>  }
>
>  static int get_dfs_referral(const unsigned int xid, struct cifs_ses *ses,
> --
> 2.7.4
>
>


-- 
Thanks,

Steve