linux-kernel - Re: [PATCH v10 11/14] exfat: add Kconfig and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200117091245.ginzffry7anqofju@pali>
Date:   Fri, 17 Jan 2020 10:12:45 +0100
From:   Pali Rohár <pali.rohar@...il.com>
To:     Namjae Jeon <namjae.jeon@...sung.com>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        gregkh@...uxfoundation.org, valdis.kletnieks@...edu, hch@....de,
        sj1557.seo@...sung.com, linkinjeon@...il.com, arnd@...db.de
Subject: Re: [PATCH v10 11/14] exfat: add Kconfig and Makefile

On Friday 17 January 2020 13:22:27 Namjae Jeon wrote:
> > > +config EXFAT_DEFAULT_IOCHARSET
> > > +	string "Default iocharset for exFAT"
> > > +	default "utf8"
> > > +	depends on EXFAT_FS
> > > +	help
> > > +	  Set this to the default input/output character set you'd
> > > +	  like exFAT to use. It should probably match the character set
> > > +	  that most of your exFAT filesystems use, and can be overridden
> > > +	  with the "iocharset" mount option for exFAT filesystems.
> > 
> > Hello! This description is incorrect. iocharset option specify what
> > character set is expected by VFS layer and not character set used by exFAT
> > filesystem. exFAT filesystem always uses UTF-16 as this is the only
> > allowed by exFAT specification.
> Hi Pali,
> 
> Could you please review updated description ?
> 
> diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
> index 9eeaa6d06..f2b0cf2c1 100644
> --- a/fs/exfat/Kconfig
> +++ b/fs/exfat/Kconfig
> @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET
>         default "utf8"
>         depends on EXFAT_FS
>         help
> -         Set this to the default input/output character set you'd
> -         like exFAT to use. It should probably match the character set
> -         that most of your exFAT filesystems use, and can be overridden
> -         with the "iocharset" mount option for exFAT filesystems.
> +         Set this to the default input/output character set to use for
> +         converting between the encoding is used for user visible filename and
> +         UTF-16 character that exfat filesystem use. and can be overridden with
> +         the "iocharset" mount option for exFAT filesystems.

Hello! This is much better. Fine for me.

-- 
Pali Rohár
pali.rohar@...il.com