linux-kernel - Re: [PATCH -next v4] mm/hotplug: silence a lockdep splat with printk()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f924bf7-835b-0176-1b12-aff4f1f4be0e@redhat.com>
Date:   Fri, 17 Jan 2020 13:53:17 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Qian Cai <cai@....pw>
Cc:     akpm@...ux-foundation.org, mhocko@...nel.org,
        sergey.senozhatsky.work@...il.com, pmladek@...e.com,
        rostedt@...dmis.org, peterz@...radead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH -next v4] mm/hotplug: silence a lockdep splat with
 printk()

On 17.01.20 13:40, Qian Cai wrote:
> 
> 
>> On Jan 17, 2020, at 3:51 AM, David Hildenbrand <david@...hat.com> wrote:
>>
>> -> you are accessing the pageblock without the zone lock. It could
>> change to "isolate" again in the meantime if I am not wrong!
> 
> Since we are just dumping the state for debugging, it should be fine to accept a bit inaccuracy here due to racing. I could put a bit comments over there.
> 

Can't we just use the zone_idx() stored in the memmap instead?

-- 
Thanks,

David / dhildenb