linux-kernel - Re: [PATCH v1 1/2] x86/msi: Enhance x86 to support platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874kwu2nih.fsf@nanos.tec.linutronix.de>
Date:   Fri, 17 Jan 2020 14:58:14 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Zha Bin <zhabin@...ux.alibaba.com>, linux-kernel@...r.kernel.org
Cc:     mst@...hat.com, jasowang@...hat.com, slp@...hat.com,
        virtio-dev@...ts.oasis-open.org, gerry@...ux.alibaba.com,
        zhabin@...ux.alibaba.com, jing2.liu@...el.com,
        chao.p.peng@...el.com
Subject: Re: [PATCH v1 1/2] x86/msi: Enhance x86 to support platform_msi

Zha Bin <zhabin@...ux.alibaba.com> writes:

> From: Liu Jiang <gerry@...ux.alibaba.com>
>
> The x86 platform currently only supports specific MSI/MSI-x for PCI
> devices. To enable MSI to the platform devices such as virtio-mmio
> device, this patch enhances x86 with platform MSI by leveraging the
> already built-in platform-msi driver (drivers/base/platform-msi.c)
> and makes it as a configurable option.

Why are you trying to make this an architecture feature instead of
having a generic implementation which can work on all architectures
which support virtio-mmio?

> Signed-off-by: Liu Jiang <gerry@...ux.alibaba.com>
> Signed-off-by: Zha Bin <zhabin@...ux.alibaba.com>
> Signed-off-by: Chao Peng <chao.p.peng@...ux.intel.com>
> Signed-off-by: Jing Liu <jing2.liu@...ux.intel.com>

This Signed-off-by chain is invalid.

Thanks,

        tglx