linux-kernel - Re: [BISECT BUG] NFS v4 root not working after 6d972518b821 ("NFS: Add fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <433863.1579270803@warthog.procyon.org.uk>
Date:   Fri, 17 Jan 2020 14:20:03 +0000
From:   David Howells <dhowells@...hat.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     dhowells@...hat.com,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna.schumaker@...app.com>,
        linux-nfs@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Scott Mayhew <smayhew@...hat.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [BISECT BUG] NFS v4 root not working after 6d972518b821 ("NFS: Add fs_context support.")

You seem to be running afoul of the check here:

	case Opt_minorversion:
		if (result.uint_32 > NFS4_MAX_MINOR_VERSION)
			goto out_of_bounds;
		ctx->minorversion = result.uint_32;
		break;

which would seem to indicate that the mount process is supplying
minorversion=X as an option.  Can you modify your kernel to print param->key
and param->string at the top of nfs_fs_context_parse_param()?  Adding
something like:

	pr_notice("NFSOP '%s=%s'\n", param->key, param->string);

will likely suffice unless you're directly driving the new mount API - in
which case param->string might be things other than a string, but that's
unlikely.  It might also be NULL, but printk should handle that.

David