linux-kernel - Re: [BISECT BUG] NFS v4 root not working after 6d972518b821 ("NFS: Add fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <464191.1579275869@warthog.procyon.org.uk>
Date:   Fri, 17 Jan 2020 15:44:29 +0000
From:   David Howells <dhowells@...hat.com>
To:     Trond Myklebust <trondmy@...merspace.com>
Cc:     dhowells@...hat.com, "krzk@...nel.org" <krzk@...nel.org>,
        "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        "smayhew@...hat.com" <smayhew@...hat.com>,
        "anna.schumaker@...app.com" <anna.schumaker@...app.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>
Subject: Re: [BISECT BUG] NFS v4 root not working after 6d972518b821 ("NFS: Add fs_context support.")

Trond Myklebust <trondmy@...merspace.com> wrote:

> It looks like someone changed the return value from the old EINVAL to
> something else? The "Numerical result out of range" message above
> suggests it has been changed to EOVERFLOW, which probably is not
> supported by 'mount'.

Ah, I see what's happened.  nfs_get_option_ui_bound() returns -ERANGE and the
new code lets this through whereas the old code converted it to -EINVAL.

David