linux-kernel - RE: [PATCH v2] NFSv4: try lease recovery on NFS4ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <041101d5cd50$e398d720$aaca8560$@gmail.com>
Date:   Fri, 17 Jan 2020 16:12:16 -0000
From:   "Robert Milkowski" <rmilkowski@...il.com>
To:     <linux-nfs@...r.kernel.org>,
        "'Trond Myklebust'" <trondmy@...merspace.com>
Cc:     "'Chuck Lever'" <chuck.lever@...cle.com>,
        "'Anna Schumaker'" <anna.schumaker@...app.com>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] NFSv4: try lease recovery on NFS4ERR_EXPIRED

Anyone please?


-----Original Message-----
From: Robert Milkowski <rmilkowski@...il.com> 
Sent: 08 January 2020 21:48
To: linux-nfs@...r.kernel.org
Cc: 'Trond Myklebust' <trondmy@...merspace.com>; 'Chuck Lever'
<chuck.lever@...cle.com>; 'Anna Schumaker' <anna.schumaker@...app.com>;
linux-kernel@...r.kernel.org
Subject: [PATCH v2] NFSv4: try lease recovery on NFS4ERR_EXPIRED

From: Robert Milkowski <rmilkowski@...il.com>

Currently, if an nfs server returns NFS4ERR_EXPIRED to open(), etc.
we return EIO to applications without even trying to recover.

Fixes: 272289a3df72 ("NFSv4: nfs4_do_handle_exception() handle revoke/expiry
of a single stateid")
Signed-off-by: Robert Milkowski <rmilkowski@...il.com>
---
 fs/nfs/nfs4proc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 76d3716..2478405
100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -481,6 +481,10 @@ static int nfs4_do_handle_exception(struct nfs_server
*server,
 						stateid);
 				goto wait_on_recovery;
 			}
+			if (state == NULL) {
+				nfs4_schedule_lease_recovery(clp);
+				goto wait_on_recovery;
+			}
 			/* Fall through */
 		case -NFS4ERR_OPENMODE:
 			if (inode) {
--
1.8.3.1