linux-kernel - Re: [PATCH v3 2/2] hwmon: (adt7475) Added attenuator bypass support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200117163252.GA26187@bogus>
Date:   Fri, 17 Jan 2020 10:32:52 -0600
From:   Rob Herring <robh@...nel.org>
To:     Logan Shaw <logan.shaw@...iedtelesis.co.nz>
Cc:     linux@...ck-us.net, jdelvare@...e.com, robh+dt@...nel.org,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Joshua.Scott@...iedtelesis.co.nz,
        Chris.Packham@...iedtelesis.co.nz, logan.shaw@...iedtelesis.co.nz
Subject: Re: [PATCH v3 2/2] hwmon: (adt7475) Added attenuator bypass support

On Fri, 17 Jan 2020 16:50:18 +1300, Logan Shaw wrote:
> 
> Added a new file documenting the adt7475 devicetree and added the four
> new properties to it.
> 
> Signed-off-by: Logan Shaw <logan.shaw@...iedtelesis.co.nz>
> ---
> ---
>  .../devicetree/bindings/hwmon/adt7475.yaml    | 90 +++++++++++++++++++
>  1 file changed, 90 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/adt7475.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
Documentation/devicetree/bindings/hwmon/adt7475.example.dts:20.11-39: ERROR (duplicate_property_names): /example-0/hwmon@2e:bypass-attenuator-in1: Duplicate property name
ERROR: Input tree has errors, aborting (use -f to force output)
scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/hwmon/adt7475.example.dt.yaml' failed
make[1]: *** [Documentation/devicetree/bindings/hwmon/adt7475.example.dt.yaml] Error 2
Makefile:1263: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1224608
Please check and re-submit.